[webkit-reviews] review denied: [Bug 92513] [chromium] Upstream Android changes to WebFrameImpl::selectRange : [Attachment 156075] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Iain Merrick <husky at google.com>'s
request for review:
Bug 92513: [chromium] Upstream Android changes to WebFrameImpl::selectRange
https://bugs.webkit.org/show_bug.cgi?id=92513

Attachment 156075: Patch
https://bugs.webkit.org/attachment.cgi?id=156075&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156075&action=review


> Source/WebKit/chromium/src/WebFrameImpl.cpp:1466
> +    if (frame()->selection()->isContentEditable()) {
> +	   startPosition =
frame()->selection()->selection().visibleStart().honorEditingBoundaryAtOrAfter(
startPosition);
> +	   endPosition =
frame()->selection()->selection().visibleEnd().honorEditingBoundaryAtOrBefore(e
ndPosition);
> +	   if (startPosition.isNull() || endPosition.isNull())
> +	       return;
> +    }

Adjustment around editing boundary is done in
VisibleSelection::VisibleSelection > VisibleSelection::validate >
VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries.