[webkit-reviews] review granted: [Bug 92348] Web Inspector: Profiles: extract save to file / load from code : [Attachment 155767] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 92348: Web Inspector: Profiles: extract save to file / load from code
https://bugs.webkit.org/show_bug.cgi?id=92348

Attachment 155767: Patch
https://bugs.webkit.org/attachment.cgi?id=155767&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155767&action=review


> Source/WebCore/inspector/front-end/FileUtils.js:83
> +	   if (this._delegate)

Can we require the delegate passed to WebInspector.ChunkedFileReader
constructor to always be non-null? This way we would avoid many null-checks and
could inline _onError.

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:790
> +WebInspector.ChunkedTransferrer = function()

Should we rename it to ChunkedTransfer for consistency?