[webkit-reviews] review denied: [Bug 92967] [GTK][WK2] Add API for suggested filename from a URI Response. : [Attachment 156024] [GTK] Add WK2 API to get suggested filename for URI responses https://bugs.webkit.org/show_bug.cgi?id=92967

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 92967: [GTK][WK2] Add API for suggested filename from a URI Response.
https://bugs.webkit.org/show_bug.cgi?id=92967

Attachment 156024:	   [GTK] Add WK2 API to get suggested filename for URI
responses	  https://bugs.webkit.org/show_bug.cgi?id=92967
https://bugs.webkit.org/attachment.cgi?id=156024&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156024&action=review


You should include a unit tests to check the new api added.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:255
> + * Returns: the suggested filename for @response, as specified by

Don't use Returns: tag twice

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:259
> + * Returns: (transfer none): the suggested filename or %NULL if none

if none -> if not present

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:260
> + * Since: 2.0

Don't add Since tags for wk2 gtk api, since we haven't released a first stable
version yet.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h:75
> +webkit_uri_response_get_suggested_filename (WebKitURIResponse *response);

parameter name should also be aligned with other methods