[webkit-reviews] review denied: [Bug 92833] REGRESSION(r102741): [Forms] In selects, when disabled, browser skips first option if not in optgroup, then selects first option in optgroup : [Attachment 155978] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 92833: REGRESSION(r102741): [Forms] In selects, when disabled, browser
skips first option if not in optgroup, then selects first option in optgroup
https://bugs.webkit.org/show_bug.cgi?id=92833

Attachment 155978: Patch 1
https://bugs.webkit.org/attachment.cgi?id=155978&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155978&action=review


Need ChangeLog improvement

> Source/WebCore/ChangeLog:9
> +	   This patch changes implementation of HTMLOptionElement::disabled()
to
> +	   follow HTML5 specification, the option element is disabled if option


This is confusing.  It's unclear that what part of the HTML5 specification it
is.
You should write ":disabled pseudo class" or add a link to the concept
"disabled" [1] because "disabled" IDL attribute is different from it.

[1]
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.
html#concept-option-disabled

> Source/WebCore/ChangeLog:15
> +	   Before this patch, HTMLSelectElement::recalcListItems() didn't pick

What do you mean by 'pick'?