[webkit-reviews] review denied: [Bug 91759] Web Inspector: count RenderStyle objects in the native memory profiler : [Attachment 155805] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91759: Web Inspector: count RenderStyle objects in the native memory
profiler
https://bugs.webkit.org/show_bug.cgi?id=91759

Attachment 155805: Patch
https://bugs.webkit.org/attachment.cgi?id=155805&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155805&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:286
> +    if (!vector || visited(vector) || !vector->data() ||
visited(vector->data()))

I think we should return immediately  if (!vector || visited(vector))
but otherwise even if vector->data() is already visited it would make
sense to add size of Vector itself if it is referenced by a pointer.