[webkit-reviews] review granted: [Bug 92935] Remove all uses of ClassInfo for JSStrings in JIT code : [Attachment 155958] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 21:50:27 PDT 2012


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 92935: Remove all uses of ClassInfo for JSStrings in JIT code
https://bugs.webkit.org/show_bug.cgi?id=92935

Attachment 155958: Patch
https://bugs.webkit.org/attachment.cgi?id=155958&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155958&action=review


r=me

> Source/JavaScriptCore/bytecode/SpeculatedType.cpp:270
> +    if (structure->typeInfo().type() == StringType)
> +	   return SpecString;

FWIW, you *could* get the JSGlobalData from
structure->globalObject()->globalData().


More information about the webkit-reviews mailing list