[webkit-reviews] review denied: [Bug 92936] Fix typo in colorSuggestionPicker.js : [Attachment 155961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 20:53:51 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92936: Fix typo in colorSuggestionPicker.js
https://bugs.webkit.org/show_bug.cgi?id=92936

Attachment 155961: Patch
https://bugs.webkit.org/attachment.cgi?id=155961&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155961&action=review


> LayoutTests/platform/chromium/TestExpectations:3337
> +BUGWK92444 :
platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appea
rance.html = PASS MISSING TEXT

IMAGE is necessary for chromium-mac-snowleopard.

>
LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scr
ollbar-appearance-expected.txt:2
> +CONSOLE MESSAGE: line 107: Check if window.pagePopupController exists for a
page-popup window.
> +CONSOLE MESSAGE: line 118: [object PagePopupController]

This check is out of scope of the test, isn't it?


More information about the webkit-reviews mailing list