[webkit-reviews] review denied: [Bug 92908] Implement computePreferredLogicalWidths on RenderGrid : [Attachment 155913] Proposed change. Added an early implementation + fixed a test.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 92908: Implement computePreferredLogicalWidths on RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=92908

Attachment 155913: Proposed change. Added an early implementation + fixed a
test.
https://bugs.webkit.org/attachment.cgi?id=155913&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155913&action=review


> Source/WebCore/rendering/RenderGrid.cpp:142
> +    return styleToUse->isHorizontalWritingMode() ? styleToUse->gridRows() :
styleToUse->gridColumns();

Use isHorizontalWritingMode() (i.e. off the RenderGrid, not the RenderStyle).
That caches the value. Then you won't need the styleToUse local variable
either.