[webkit-reviews] review granted: [Bug 92696] DFG should hoist structure checks : [Attachment 155893] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 92696: DFG should hoist structure checks
https://bugs.webkit.org/show_bug.cgi?id=92696

Attachment 155893: the patch
https://bugs.webkit.org/attachment.cgi?id=155893&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155893&action=review


r+, unsure about the lack of any kind of enum / name for the ballot constants.

> Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp:412
> +	   noticeStructureCheck(variable, set.singletonStructure());

I feel like I've seen this idiom before - I could be wrong?
- maybe we want a singletonStructureOrNull, or just make singletonStructure()
provide this behavior by default?

> Source/JavaScriptCore/dfg/DFGVariableAccessData.h:156
> +	   m_votes[1] = 0;

o_O

0 & 1 - are you sure?