[webkit-reviews] review denied: [Bug 92794] [chromium] deviceViewportSize cleanup : [Attachment 155910] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 92794: [chromium] deviceViewportSize cleanup
https://bugs.webkit.org/show_bug.cgi?id=92794

Attachment 155910: Patch
https://bugs.webkit.org/attachment.cgi?id=155910&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155910&action=review


> Source/WebKit/chromium/src/WebLayerTreeView.cpp:100
> +    if (!deviceViewportSize.isEmpty())
> +	   m_private->layerTreeHost()->setViewportSize(layoutViewportSize,
deviceViewportSize);
> +    else
> +	   m_private->layerTreeHost()->setViewportSize(layoutViewportSize,
layoutViewportSize);

I know it's just temporary, but you need to handle non-1 device scale factors
to not break Aura in the meantime.

Would it be easier to just ignore this deviceViewportSize parameter in all
cases until the Chromium side of this change lands, and just call
m_private->layerTreeHost()->setViewportSize whenever layoutViewportSize or
deviceScale changes?