[webkit-reviews] review granted: [Bug 92678] Month-year selector on calendar picker should be touch friendly. : [Attachment 155809] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kevin Ellis
<kevers at chromium.org>'s request for review:
Bug 92678: Month-year selector on calendar picker should be touch friendly.
https://bugs.webkit.org/show_bug.cgi?id=92678

Attachment 155809: Patch
https://bugs.webkit.org/attachment.cgi?id=155809&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155809&action=review


> Source/WebCore/ChangeLog:30
> +	   Summary of changes:
> +	     - Changed selector popup from a list-box to an absolute positined
div
> +	       to enable better CSS control over appearance.
> +	     - Added styles for menu content wrapper and month-year entries
> +	       to layout as a scrollable table within the popup window. 
> +	     - Add style to highlight selected month-year.
> +	     - Added rules to enlarge entries in the popup menu on devices that

> +	       support touch.
> +	     - Update attachTo to create popup menu and content wrapper.
> +	     - Update redraw to populate table in popup rather than listbox.
> +	     - Update showPopup to set the scroll position and add padding to 
> +	       accomodate a scrollbar as required.
> +	     - Update closePopup to restore focus to the calendar.
> +	     - Add support for keyboard navigation in handleMonthPopupKey.
> +	     - Added handleMouseMove to update the selected month-year on
hover.
> +	     - Update handleYearMonthChange to retrieve the value from the
selected
> +	       month-year.

Such comments should be put to the file/function list below.