[webkit-reviews] review granted: [Bug 26371] SVGLangSpace duplicates xml:lang and xml:space values : [Attachment 141628] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 15:50:26 PDT 2012


Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 26371: SVGLangSpace duplicates xml:lang and xml:space values
https://bugs.webkit.org/show_bug.cgi?id=26371

Attachment 141628: Patch
https://bugs.webkit.org/attachment.cgi?id=141628&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.  Unclear to me why isKnownAttribute is needed for the early returns.  It
would also be OK to let execution continue and just fall off the end of
parseMappedAttribute.


More information about the webkit-reviews mailing list