[webkit-reviews] review denied: [Bug 92557] [V8] TypedArray binding performance improvements : [Attachment 155650] updated patch to address review

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied arno. <arno at renevier.net>'s request
for review:
Bug 92557: [V8] TypedArray binding performance improvements
https://bugs.webkit.org/show_bug.cgi?id=92557

Attachment 155650: updated patch to address review
https://bugs.webkit.org/attachment.cgi?id=155650&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155650&action=review


Thanks, this looks almost perfect. One issue which is confusing, therefore the
r-. If you can clean this up I'll r+ the next version.

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:48
> +v8::Handle<v8::Value> wrapWebGLArrayBuffer(const v8::Arguments& args,
WrapperTypeInfo* type, ArrayClass array, v8::ExternalArrayType arrayType, bool
hasIndexer)

This is a misleading name. It has nothing to do with ArrayBuffers. Please call
it "wrapTypedArray" or "wrapArrayBufferView". (The use of "WebGL" throughout
this file is historical and is something that should be cleaned up in a
separate patch.)