[webkit-reviews] review granted: [Bug 92556] TypedArray set method is slow when called with another typed array : [Attachment 155645] updated patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted arno. <arno at renevier.net>'s
request for review:
Bug 92556: TypedArray set method is slow when called with another typed array
https://bugs.webkit.org/show_bug.cgi?id=92556

Attachment 155645: updated patch
https://bugs.webkit.org/attachment.cgi?id=155645&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155645&action=review


Thanks, this looks better. One minor naming convention issue I'd appreciate if
you'd clean up before committing. r=me

> Source/WTF/wtf/TypedArrayBase.h:76
> +    bool inbound(unsigned offset, unsigned pos) const

Please name this some sort of verb like "checkInboundData".