[webkit-reviews] review granted: [Bug 92901] [chromium] Move compositor HUD font atlas generation out of compositor core : [Attachment 155864] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 92901: [chromium] Move compositor HUD font atlas generation out of
compositor core
https://bugs.webkit.org/show_bug.cgi?id=92901

Attachment 155864: Patch
https://bugs.webkit.org/attachment.cgi?id=155864&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155864&action=review


R=me, with some drive-by cleanup comments on code you're moving around.

> Source/WebCore/platform/graphics/chromium/CompositorHUDFontAtlas.cpp:43
> +#define FONT_HEIGHT 14

Unused?

> Source/WebCore/platform/graphics/chromium/CompositorHUDFontAtlas.cpp:59
> +    fontHeight = 14;
> +
> +    OwnPtr<SkCanvas> canvas = adoptPtr(skia::CreateBitmapCanvas(ATLAS_SIZE,
ATLAS_SIZE, false /* opaque */));

This baked in font height and atlas size is kind of a mess, but it's not your
fault.