[webkit-reviews] review denied: [Bug 92900] [chromium] Upstream android's FlingAnimator : [Attachment 155863] patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 92900: [chromium] Upstream android's FlingAnimator
https://bugs.webkit.org/show_bug.cgi?id=92900

Attachment 155863: patch
https://bugs.webkit.org/attachment.cgi?id=155863&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155863&action=review


> Source/WebKit/chromium/src/android/FlingAnimator.cpp:30
> +#include "base/android/jni_android.h"
> +#include "base/android/scoped_java_ref.h"

This #include won't compile in all configs and is a bad dependency.

I don't think any WebKit code should know about JNI.  Previously when we talked
about this animator we had (I thought) decided that this code should call out
to chromium code via WebKit API and chromium code can do whatever communication
with JNI it needs to.