[webkit-reviews] review granted: [Bug 92856] [chromium] Improve garbage collector hint if page uses Canvas contexts : [Attachment 155766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 11:24:04 PDT 2012


Adam Barth <abarth at webkit.org> has granted Ulan Degenbaev <ulan at chromium.org>'s
request for review:
Bug 92856: [chromium] Improve garbage collector hint if page uses Canvas
contexts
https://bugs.webkit.org/show_bug.cgi?id=92856

Attachment 155766: Patch
https://bugs.webkit.org/attachment.cgi?id=155766&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155766&action=review


> Source/WebCore/bindings/v8/V8Binding.h:229
> +	   void setGarbageCollectionHint() { m_garbageCollectionHint = true; }
> +	   void clearGarbageCollectionHint() { m_garbageCollectionHint = false;
}
> +	   bool isGarbageCollectionHint() const { return
m_garbageCollectionHint; }

How about:

void setShouldCollectGarbageSoon(bool flag) { m_shouldCollectGarbageSoon =
flag; }
bool shouldCollectGarbageSoon() const { return m_shouldCollectGarbageSoon; }


More information about the webkit-reviews mailing list