[webkit-reviews] review granted: [Bug 92813] [chromium] Make WebKit API support draggable region change update : [Attachment 155685] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 92813: [chromium] Make WebKit API support draggable region change update
https://bugs.webkit.org/show_bug.cgi?id=92813

Attachment 155685: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=155685&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155685&action=review


> Source/Platform/chromium/public/WebDraggableRegion.h:40
> +struct WebDraggableRegion {

This looks like a wrapper for DashboardRegionValue, which is a WebCore concept,
not a WebCore/platform concept.  Therefore, this header should be in
WebKit/chromium/public rather than in Platform.

> Source/Platform/chromium/public/WebDraggableRegion.h:44
> +    int type;

Is this really an enum?  Should we create an API for the enum values so we can
COMPILE_ASSERT that they match their WebCore counterparts?

> Source/WebKit/chromium/public/WebViewClient.h:384
> +    // Draggable regions
----------------------------------------------------

Two blank lines before section headings.