[webkit-reviews] review granted: [Bug 92887] run-perf-tests throws an exception when the output json is malformed : [Attachment 155843] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 92887: run-perf-tests throws an exception when the output json is malformed
https://bugs.webkit.org/show_bug.cgi?id=92887

Attachment 155843: Patch
https://bugs.webkit.org/attachment.cgi?id=155843&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155843&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:56
> +    _EXIT_CODE_BAD_PREPARATION = -5

Nit: the leading underscore makes these look like they're supposed to be
private, but you return them from run(); should they be public (and have no
leading underscore)?