[webkit-reviews] review denied: [Bug 92845] Regression(r124135): nrwt: --verbose logging does not work right on windows : [Attachment 155768] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 1 08:56:04 PDT 2012
Dirk Pranke <dpranke at chromium.org> has denied Thiago Marcos P. Santos
<tmpsantos at gmail.com>'s request for review:
Bug 92845: Regression(r124135): nrwt: --verbose logging does not work right on
windows
https://bugs.webkit.org/show_bug.cgi?id=92845
Attachment 155768: Patch
https://bugs.webkit.org/attachment.cgi?id=155768&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Nope, this tests the opposite of what it needs to test (which is that --verbose
propagates to the subprocess). I should add a comment to that effect.
We'll have to fix the results_dir problem differently.
More information about the webkit-reviews
mailing list