[webkit-reviews] review requested: [Bug 92678] Month-year selector on calendar picker should be touch friendly. : [Attachment 155527] Patch

[bugzilla-daemon at webkit.org]

Kevin Ellis <kevers at chromium.org> has asked  for review:
Bug 92678: Month-year selector on calendar picker should be touch friendly.
https://bugs.webkit.org/show_bug.cgi?id=92678

Attachment 155527: Patch
https://bugs.webkit.org/attachment.cgi?id=155527&action=review

------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155527&action=review


>> Source/WebCore/ChangeLog:31
>> +	    (YearMonthController.prototype._handleYearMonthChange):
> 
> Please update the list, and add comments for each of entries.

Done.

>> Source/WebCore/Resources/calendarPicker.js:443
>> +	this._monthPopup.setAttribute('tabindex', 0);
> 
> nit: this._monthPopup.tabIndex = 0 is simpler and consistent with other part.


Done.

>> Source/WebCore/Resources/calendarPicker.js:601
>> +	    this._monthPopup.style.setProperty('-webkit-padding-end', '15px');
> 
> nit: ...style.webkitPaddingEnd = '15px' is simpler and consistent with
others.

Done.