[webkit-reviews] review denied: [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC : [Attachment 155267] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 1 07:43:43 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 92342: Web Inspector [JSC]: Support multi instance for
PageScriptDebugServer of JSC
https://bugs.webkit.org/show_bug.cgi?id=92342
Attachment 155267: Patch
https://bugs.webkit.org/attachment.cgi?id=155267&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155267&action=review
> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:105
> void PageScriptDebugServer::removeListener(ScriptDebugListener* listener,
Page* page)
We can make v8's implementation also keep a pointer to the Page and remove the
second argument from the method. Can be done in another patch.
> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:143
> + if (page && page == m_page)
I don't think we need page == m_page check as PageScriptDebugServer listens to
only one page.
> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:152
> + if (page && page == m_page)
Ditto.
> Source/WebCore/bindings/js/PageScriptDebugServer.h:52
> + static PageDebugServerMap& pageServerMap();
This one should be private.
> Source/WebCore/inspector/InspectorProfilerAgent.cpp:107
> + ScriptDebugServer* server = new
WorkerScriptDebugServer(m_workerContext);
It will create WorkerScriptDebugServer that is never deleted.
> Source/WebCore/inspector/InspectorProfilerAgent.cpp:235
> + scriptDebugServer().recompileAllJSFunctionsSoon();
Can we avoid creating ScriptDebugServer just to recompile js functions?
More information about the webkit-reviews
mailing list