[webkit-reviews] review granted: [Bug 92743] Web Inspector: test native memory instrumentation code with help of unittests : [Attachment 155799] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 07:18:54 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 92743: Web Inspector: test native memory instrumentation code with help of
unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Attachment 155799: Patch
https://bugs.webkit.org/attachment.cgi?id=155799&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155799&action=review


> Source/WebCore/inspector/MemoryInstrumentationImpl.h:54
> +    size_t reportedSize() const

reportedSizeForAllTypes?

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:46
> +

Please remove 1 blank like

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:85
> +TEST(MemoryInstrumentationTest, ptrVsRef)

Split this into two tests.

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:90
> +	   Instrumented* instrumented = new Instrumented;

You may need adoptPtr(new Instrumented).leakPtr() to make some scripts happy.

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:100
> +	   impl.addRootObject(instrumented);

If it is a root object, its size shouldn't be reported yet.


More information about the webkit-reviews mailing list