[webkit-reviews] review denied: [Bug 91759] Web Inspector: count RenderStyle objects in the native memory profiler : [Attachment 155798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 06:57:19 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91759: Web Inspector: count RenderStyle objects in the native memory
profiler
https://bugs.webkit.org/show_bug.cgi?id=91759

Attachment 155798: Patch
https://bugs.webkit.org/attachment.cgi?id=155798&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155798&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:286
> +    if (!vector || visited(vector))

We should keep the old check in addition to the new one:
visited(vector->data()) as several vectors may share same buffer.


More information about the webkit-reviews mailing list