[webkit-reviews] review denied: [Bug 92743] Web Inspector: test native memory instrumentation code with help of unittests : [Attachment 155793] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 06:43:17 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 92743: Web Inspector: test native memory instrumentation code with help of
unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Attachment 155793: Patch
https://bugs.webkit.org/attachment.cgi?id=155793&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155793&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:59
>	   OwningTraits<T>::addInstrumentedObject(this, t);

addInstrumentedObject(this, t)

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:48
> +class MemoryInstrumentationImpl : public MemoryInstrumentation {

Please reuse existing MemoryInstrumentationImpl.


More information about the webkit-reviews mailing list