[webkit-reviews] review granted: [Bug 92748] Web Inspector: add CSSStyleSheet memory instrumentation : [Attachment 155537] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 92748: Web Inspector: add CSSStyleSheet memory instrumentation
https://bugs.webkit.org/show_bug.cgi?id=92748

Attachment 155537: Patch
https://bugs.webkit.org/attachment.cgi?id=155537&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=155537&action=review


r=me

> Source/WebCore/css/StylePropertySet.cpp:1084
> +    MemoryClassInfo<StylePropertySet> info(memoryObjectInfo, this,
MemoryInstrumentation::CSS);
> +    if (m_isMutable)
> +	   info.addVectorPtr(m_mutablePropertyVector);
> +    else
> +	   info.addRawBuffer(m_properties, m_arraySize * sizeof(CSSProperty));

CSSProperty contains a CSSValue. You are not taking its size (which may be
significant) into account. Is this something you plan to do later?