[webkit-reviews] review denied: [Bug 92735] [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals : [Attachment 155736] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 00:51:11 PDT 2012


Hajime Morrita <morrita at google.com> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 92735: [DRT] LTC:: Move printing related APIs from LayoutTestController to
Internals
https://bugs.webkit.org/show_bug.cgi?id=92735

Attachment 155736: Patch
https://bugs.webkit.org/attachment.cgi?id=155736&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155736&action=review


Basically looks good. Added a few comment.

> Source/WebCore/testing/Internals.cpp:1137
> +	   return -1;

Could you throw an exception rather than returning this?
I think it could break compatibility (or can be compatible with tiny change.)

> Source/WebCore/testing/Internals.cpp:1145
> +	   return String();

Ditto.

> Source/WebCore/testing/Internals.cpp:1153
> +	   return String();

Ditto.


More information about the webkit-reviews mailing list