[webkit-reviews] review granted: [Bug 85231] Fixed position objects that are removed from the DOM don't kick off fixed position recalculation : [Attachment 139516] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 85231: Fixed position objects that are removed from the DOM don't kick off
fixed position recalculation
https://bugs.webkit.org/show_bug.cgi?id=85231

Attachment 139516: Patch
https://bugs.webkit.org/attachment.cgi?id=139516&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139516&action=review


Is there a way to write a regression test for this? Normally we would not want
to land a code change without a test.

> Source/WebCore/rendering/RenderBox.cpp:259
> +    if (frameView && styleToUse) {

I’d suggest putting the styleToUse if before even fetching the frameView. I’d
write this:

    if (styleToUse) {
	if (RenderView* view = this->view()) {
	    if (FrameView* frameView = view->frameView()) {

> Source/WebCore/rendering/RenderBox.cpp:260
> +	   // If this renderer is owning renderer for the frameview's custom
scrollbars,

I think it should be “frame view” or “frameView”, not “frameview”.