[webkit-reviews] review granted: [Bug 84297] FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted : [Attachment 138728] Patch v4

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 84297: FrameLoaderClient::dispatchWillSendSubmitEvent() should be given
more information about the form being submitted
https://bugs.webkit.org/show_bug.cgi?id=84297

Attachment 138728: Patch v4
https://bugs.webkit.org/attachment.cgi?id=138728&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review


> Source/WebCore/html/HTMLFormElement.h:114
> +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;

FormState calls what this function collects 'textFieldValues', which I think is
somewhat more descriptive than 'textFieldData'. Perhaps you should call this
'getTextFieldValues'. Also, since the StyleBot wants you to give an argument
name here, you should use the same name you used in the function's definition.