[webkit-reviews] review granted: [Bug 52444] After appending MATHM with jquery the table renders with overlaps : [Attachment 138933] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 52444: After appending MATHM with jquery the table renders with overlaps
https://bugs.webkit.org/show_bug.cgi?id=52444

Attachment 138933: Patch
https://bugs.webkit.org/attachment.cgi?id=138933&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138933&action=review


> Source/WebCore/rendering/mathml/RenderMathMLBlock.h:111
> +    void sizeChildrenInWide();

As far as the contract for this function goes, if you change it, you would have
to rename your function which would be annoying as what it does is only
preparing your child. Note that I am a native speaker which may be why "size
children in wide" doesn't speak at all to me. Please consider renaming to
anything that makes more sense.

> Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:67
> -    if (height == m_stretchHeight)
> +    if (m_stretchHeight == static_cast<int>(height * gOperatorExpansion))
>	   return;
>      m_stretchHeight = static_cast<int>(height * gOperatorExpansion);

You can factor this out to avoid 2 conversions:

int operatorExpandedHeight = height * gOperatorExpansion;
if (m_stretchHeight == operatorExpandedHeight)
   return;
m_stretchHeight = operatorExpandedHeight;