[webkit-reviews] review granted: [Bug 84787] WebGLRenderingContext methods should throw TypeError for not enough arguments : [Attachment 139484] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 11:41:18 PDT 2012


Kenneth Russell <kbr at google.com> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 84787: WebGLRenderingContext methods should throw TypeError for not enough
arguments
https://bugs.webkit.org/show_bug.cgi?id=84787

Attachment 139484: Patch
https://bugs.webkit.org/attachment.cgi?id=139484&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks good. r=me

Thinking more about incorporating this test into the WebGL conformance suite:
that suite doesn't use test expectations, so it would be necessary to
explicitly check the exception object and verify that it is a TypeError. Is
that feasible?


More information about the webkit-reviews mailing list