[webkit-reviews] review denied: [Bug 84211] Call default constructor for CSSImageSetValue::ImageWithScale in CSSImageSetValue::bestImageScaleFactor(). : [Attachment 137915] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 08:47:31 PDT 2012


Andreas Kling <kling at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 84211: Call default constructor for CSSImageSetValue::ImageWithScale in
CSSImageSetValue::bestImageScaleFactor().
https://bugs.webkit.org/show_bug.cgi?id=84211

Attachment 137915: Patch
https://bugs.webkit.org/attachment.cgi?id=137915&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
If anything, we should add a default constructor for ImageWithScale.
This spot fix will not protect against someone doing "ImageWithScale foo;"
somewhere else in the future and getting an uninitialized m_scaleFactor.


More information about the webkit-reviews mailing list