[webkit-reviews] review requested: [Bug 83283] [chromium] Ensure that animations continue to run when transform-style is changed : [Attachment 139450] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 83283: [chromium] Ensure that animations continue to run when
transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283

Attachment 139450: Patch
https://bugs.webkit.org/attachment.cgi?id=139450&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #6)
> (From update of attachment 136777 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=136777&action=review
>
> +1 to layout test to test this case. Do we need something else that tests the
transfer code?
Would it be acceptable to submit the layout test in a separate CL? Layout tests
with threaded animation have been delayed.
>
> > Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:589
> > +	     m_transformLayer->layerAnimationController()->setForceSync();
>
> is this forceSync required? Does it make sense for setting an animation
controller to internally force sync?
Done.