[webkit-reviews] review granted: [Bug 85158] Accumulation for values-animation is broken : [Attachment 139402] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 85158: Accumulation for values-animation is broken
https://bugs.webkit.org/show_bug.cgi?id=85158

Attachment 139402: Patch
https://bugs.webkit.org/attachment.cgi?id=139402&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139402&action=review


> Source/WebCore/svg/SVGAnimatedColor.cpp:73
> +    Color& toAtEndOfDurationColor = toAtEndOfDuration->color();

This is a curious idiom. A getter that returns a non-const reference. Do we
actually modify the color through this reference?