[webkit-reviews] review denied: [Bug 85139] MessagePort must set m_closed to be true at the end of MessagePort::close function : [Attachment 139363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 28 11:15:37 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Li Yin <li.yin at intel.com>'s
request for review:
Bug 85139: MessagePort must set m_closed to be true at the end of
MessagePort::close function
https://bugs.webkit.org/show_bug.cgi?id=85139

Attachment 139363: Patch
https://bugs.webkit.org/attachment.cgi?id=139363&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139363&action=review


The change looks reasonable. r- due to missing a test. I think this change is
testable.

> Source/WebCore/ChangeLog:12
> +	   No new tests. The test can be found from
http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/messagechannel_close.
htm

Would you add the test to LayoutTests?


More information about the webkit-reviews mailing list