[webkit-reviews] review denied: [Bug 85131] [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme : [Attachment 139348] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sudarsana Nagineni
<naginenis at gmail.com>'s request for review:
Bug 85131: [GTK] DRT needs an implementation of
layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=85131

Attachment 139348: Patch
https://bugs.webkit.org/attachment.cgi?id=139348&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139348&action=review


Looks good, but there's one change I suggest...

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:916
> +    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(scheme);
> +    GOwnPtr<gchar> schemeBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
> +    JSStringGetUTF8CString(scheme, schemeBuffer.get(), bufferSize);
> +
> +    SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden,
String::fromUTF8(schemeBuffer.get()));

Most of the DumpRenderTreeSupportGtk method use char* instead of JSString. You
should do the conversion in LayoutTestController.