[webkit-reviews] review granted: [Bug 36704] SVGAnimateColorElement doesn't support by/to animations properly : [Attachment 139351] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 36704: SVGAnimateColorElement doesn't support by/to animations properly
https://bugs.webkit.org/show_bug.cgi?id=36704

Attachment 139351: Patch
https://bugs.webkit.org/attachment.cgi?id=139351&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=139351&action=review


r=me

> Source/WebCore/ChangeLog:8
> +	   Switch AnimatedColorAnimator to use the standard
animateAdditveNumber() method, taking progress & repeatCount into account.

animateAdditveNumber <- typo

> Source/WebCore/svg/SVGAnimatedColor.cpp:94
> +    animatedColor = ColorDistance::clampColor(static_cast<int>(animatedRed),
static_cast<int>(animatedGreen), static_cast<int>(animatedBlue),
static_cast<int>(animatedAlpha));

Is static_cast<int>(floatColor) really the correct rounding?