[webkit-reviews] review granted: [Bug 85115] Remove SHADER_COMPILER constant : [Attachment 139312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 18:12:31 PDT 2012


Darin Adler <darin at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 85115: Remove SHADER_COMPILER constant
https://bugs.webkit.org/show_bug.cgi?id=85115

Attachment 139312: Patch
https://bugs.webkit.org/attachment.cgi?id=139312&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139312&action=review


> LayoutTests/fast/canvas/webgl/constants.html:449
> +NUM_COMPRESSED_TEXTURE_FORMATS : 0x86A2,
> +FIXED			  : 0x140C,
> +ACTIVE_UNIFORM_MAX_LENGTH	  : 0x8B87,
> +ACTIVE_ATTRIBUTE_MAX_LENGTH	  : 0x8B8A,
> +EXTENSIONS			  : 0x1F03,
> +INFO_LOG_LENGTH		  : 0x8B84,
> +SHADER_SOURCE_LENGTH 	  : 0x8B88,
> +SHADER_COMPILER		  : 0x8DFA,
> +SHADER_BINARY_FORMATS	  : 0x8DF8,
> +NUM_SHADER_BINARY_FORMATS	  : 0x8DF9,

Heh, it’s funny to have the actual values here for the removed constants.


More information about the webkit-reviews mailing list