[webkit-reviews] review granted: [Bug 82922] border-image with image-set does not render correctly when viewed at 2x : [Attachment 139310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 18:01:20 PDT 2012


mitz at webkit.org has granted Beth Dakin <bdakin at apple.com>'s request for review:
Bug 82922: border-image with image-set does not render correctly when viewed at
2x
https://bugs.webkit.org/show_bug.cgi?id=82922

Attachment 139310: Patch
https://bugs.webkit.org/attachment.cgi?id=139310&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=139310&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1084
> +    float imageScaleFactorAdjustRatio = 1 / image->imageScaleFactor();

Not sure this variable is needed. The word “ratio” doesn’t mean “reciprocal”,
so this name is rather meaningless.


More information about the webkit-reviews mailing list