[webkit-reviews] review requested: [Bug 84601] [chromium] Add pause and resume support for accelerated css animations. : [Attachment 139257] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 84601: [chromium] Add pause and resume support for accelerated css
animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Attachment 139257: Patch
https://bugs.webkit.org/attachment.cgi?id=139257&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #7)
> (From update of attachment 139253 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=139253&action=review
>
> Great, R=me.	Thanks for moving the time rebase - I'd like to keep as much of
the compositor interface monotonic time as possible and keep WebCore-specific
fiddly bits in GLC
>
> > Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:48
> > +#include <wtf/CurrentTime.h>
> > +
>
> can kill this now
Done.
>
> > Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h:145
> > +	 // there is absolutely no need for clients of this controller to
kmonotonicTime
>
> typo - looks like a bad search->replace of "now"->"monotonicTime"
D'oh. Fixed.