[webkit-reviews] review granted: [Bug 84601] [chromium] Add pause and resume support for accelerated css animations. : [Attachment 139253] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 84601: [chromium] Add pause and resume support for accelerated css
animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Attachment 139253: Patch
https://bugs.webkit.org/attachment.cgi?id=139253&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139253&action=review


Great, R=me.  Thanks for moving the time rebase - I'd like to keep as much of
the compositor interface monotonic time as possible and keep WebCore-specific
fiddly bits in GLC

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:48
> +#include <wtf/CurrentTime.h>
> +

can kill this now

> Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h:145
> +    // there is absolutely no need for clients of this controller to
kmonotonicTime

typo - looks like a bad search->replace of "now"->"monotonicTime"