[webkit-reviews] review granted: [Bug 85047] [EFL][DRT] EFL should sanitize pulseaudio module configuration too : [Attachment 139168] Moving pulseaudio unload/restore to shared class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 11:43:44 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Dominik Röttsches
<dominik.rottsches at linux.intel.com>'s request for review:
Bug 85047: [EFL][DRT] EFL should sanitize pulseaudio module configuration too
https://bugs.webkit.org/show_bug.cgi?id=85047

Attachment 139168: Moving pulseaudio unload/restore to shared class
https://bugs.webkit.org/attachment.cgi?id=139168&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I'm R+'ing this because you presumably didn't write this code and are just
moving it around, but the code should really be using the FileSystem and
Executive classes, and have some unit tests rather than talking to os.path and
subprocess directly :(.


More information about the webkit-reviews mailing list