[webkit-reviews] review granted: [Bug 85030] [chromium] Separate IOSurface layer type from texture layers : [Attachment 139133] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 85030: [chromium] Separate IOSurface layer type from texture layers
https://bugs.webkit.org/show_bug.cgi?id=85030

Attachment 139133: Patch
https://bugs.webkit.org/attachment.cgi?id=139133&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139133&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:52
> +    // FIXME: it seems there is no layer renderer / GraphicsContext3D
available here. Ideally we
> +    // would like to delete m_ioSurfaceTextureId.

This feels kind of like a job for TextureManager/ManagedTexture, but those
classes aren't quite smart enough to handle IO surface textures.