[webkit-reviews] review granted: [Bug 82460] [Chromium] Selectively retrieve text around a touched point : [Attachment 137574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 10:38:10 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Leandro Graciá
Gil <leandrogracia at chromium.org>'s request for review:
Bug 82460: [Chromium] Selectively retrieve text around a touched point
https://bugs.webkit.org/show_bug.cgi?id=82460

Attachment 137574: Patch
https://bugs.webkit.org/attachment.cgi?id=137574&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137574&action=review


> Source/WebKit/chromium/src/WebRange.cpp:124
> +

nit: delete extra new line

> Source/WebKit/chromium/src/WebSurroundingText.cpp:43
> +void WebSurroundingText::initialize(const WebHitTestResult& hitTestInfo,
size_t maxLength)

it could also make sense for these to be static create functions.


More information about the webkit-reviews mailing list