[webkit-reviews] review requested: [Bug 84982] [BlackBerry] run-time websocket availability check was lost : [Attachment 139213] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 27 10:02:57 PDT 2012
Joe Mason <jmason at rim.com> has asked for review:
Bug 84982: [BlackBerry] run-time websocket availability check was lost
https://bugs.webkit.org/show_bug.cgi?id=84982
Attachment 139213: patch
https://bugs.webkit.org/attachment.cgi?id=139213&action=review
------- Additional Comments from Joe Mason <jmason at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139213&action=review
>> Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp:32
>> +#include "WebSocket.h"
>
> Found header this file implements after other header. Should be: config.h,
primary header, blank line, and then alphabetically sorted.
[build/include_order] [4]
This is a false positive. Filed bug 85075. For now this will have to be
committed by hand.
More information about the webkit-reviews
mailing list