[webkit-reviews] review granted: [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API : [Attachment 138137] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Min Qin
<qinmin at chromium.org>'s request for review:
Bug 84414: Expose a flag so that fullscreen video on android can work with
FULLSCREEN_API
https://bugs.webkit.org/show_bug.cgi?id=84414

Attachment 138137: Patch
https://bugs.webkit.org/attachment.cgi?id=138137&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138137&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:1592
>      if (m_client && m_client->enterFullScreen())

so then on the chromium side you will make this enterFullScreen()
method always return false?  or, will you try to make fullscreen
mode work for non-video elements too?