[webkit-reviews] review denied: [Bug 84306] [Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to a rounding error. : [Attachment 139067] Patch.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 84306: [Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to
a rounding error.
https://bugs.webkit.org/show_bug.cgi?id=84306

Attachment 139067: Patch.
https://bugs.webkit.org/attachment.cgi?id=139067&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139067&action=review


Thread safety issues with this patch - calling WebLayerTreeRenderer functions
from the main thread and renderer thread.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:553
> +    QRect result(floor(mappedRect.x()), floor(mappedRect.y()),
floor(mappedRect.width()), floor(mappedRect.height()));
> +    return result;

return QRect(floor(mappedRect.x()), floor(mappedRect.y()),
floor(mappedRect.width()), floor(mappedRect.height()));