[webkit-reviews] review requested: [Bug 80400] [Qt] Set WebCore imagedecoders as default, add fallback to QImageDecoder : [Attachment 139180] same as last + MIMETypeRegistry.cpp

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 80400: [Qt] Set WebCore imagedecoders as default, add fallback to
QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Attachment 139180: same as last + MIMETypeRegistry.cpp
https://bugs.webkit.org/attachment.cgi?id=139180&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #16)
> (From update of attachment 136448 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=136448&action=review
> 
> r=me. There's a style nitpick to fix before landing and the diff in bugzilla
also shows "new mode 100755" for
Source/WebCore/platform/graphics/qt/ImageDecoderQt.h, which would an incorrect
mode for the file (should remain 100644).

Thanks, fixed!

> >> Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp:192
> >> +	  QImage image(reinterpret_cast<uchar*>(buffer->getAddr(0,0)),
imageSize.width(), imageSize.height(), sizeof(ImageFrame::PixelData) *
imageSize.width(), m_reader->imageFormat());
> > 
> > Missing space after ,  [whitespace/comma] [3]
> 
> The style bot is right here :)

Fixed!

Since I removed the QT_IMAGE_DECODER macro I needed to edit
MIMETypeRegistry.cpp and
Source/WebKit/blackberry/WebCoreSupport/AboutDataEnableFeatures.in
(+changelogs) also. 
Please you have a look at these, after that we will be ready to commit the
change.