[webkit-reviews] review granted: [Bug 66684] Implement high-resolution time via window.performance.now() : [Attachment 139155] ZeroBasedTime

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 66684: Implement high-resolution time via window.performance.now()
https://bugs.webkit.org/show_bug.cgi?id=66684

Attachment 139155: ZeroBasedTime
https://bugs.webkit.org/attachment.cgi?id=139155&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139155&action=review


Thanks again for the updates. Sending an r+ now, but it is probably worth
double checking w/ simonjam to make sure he is happy before landing.

> Source/WebCore/ChangeLog:3
> +	   Implement high-resolution time via window.performance.now()

Probably worth mentioning the prefixing in the ChangeLog somewhere.

> Source/WebCore/loader/DocumentLoadTiming.h:48
> +    double convertMonotonicTimeToZeroBasedDocumentTime(double monotonicTime)
const;

Nit: the param really doesn't need to be named here or above. It is redundant
with the method name.