[webkit-reviews] review granted: [Bug 84824] SVG inline style of 'marker-*' does not override : [Attachment 139092] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 84824: SVG inline style of 'marker-*' does not override
https://bugs.webkit.org/show_bug.cgi?id=84824

Attachment 139092: Patch
https://bugs.webkit.org/attachment.cgi?id=139092&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139092&action=review


Looks great, r=me. Please fix following before landing:

> LayoutTests/svg/custom/inline-style-overrides-markers.svg:20
> +  <line x1="100" y1="100" x2="100" y2="100" style="marker-start:
none;marker-mid: none;marker-end: none;" />

I'd propose to draw the (stroked) line, even though no markers are visible. And
empty expected.svg looks weird :-)